Skip to content

[hotfix] fix primary key conflict issue caused by multiple insertions in single-node persistence. #4177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
czy006 wants to merge 1 commit into from
Closed

[hotfix] fix primary key conflict issue caused by multiple insertions in single-node persistence. #4177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions amoro-ams/src/main/java/org/apache/amoro/server/table/DefaultTableService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -850,12 +850,11 @@ private boolean triggerTableAdded(
// else: follower does not assign; meta.bucketId remains null until leader assigns
}

doAs(TableRuntimeMapper.class, mapper -> mapper.insertRuntime(meta));

// Only skip local runtime creation when master-slave mode is fully wired (bucketAssignStore
// is non-null). When bucketAssignStore is null (e.g. 3-arg test constructor), fall through
// and create the runtime in memory as in non-master-slave mode.
if (isMasterSlaveMode && haContainer != null && bucketAssignStore != null) {
doAs(TableRuntimeMapper.class, mapper -> mapper.insertRuntime(meta));
return true;
}

Expand Down
Loading