[AMORO-4034][Improvement]: MaintainerMetrics Unified interface and Report

[czy006]

[Improvement]: MaintainerMetrics Unified interface and Report (#4034)

Why are the changes needed?

Close #4034 .

Brief change log

• MaintainerMetrics interface is abstracted to support a multi-lake architecture
• Maintainer Metrics add other maintainer metrics interface: such as expireSnapshots/expireData/cleanDanglingDeleteFiles/autoCreateTags
• MaintainerMetrics OrphanDataFiles method Change to a more general implementation

How was this patch tested?

• Add some test cases that check the changes thoroughly including negative and positive cases if possible

• Add screenshots for manual tests if appropriate

• Run test locally before making a pull request

Documentation

• Does this pull request introduce a new feature? (yes / no)
• If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

[codecov-commenter]

Codecov Report

❌ Patch coverage is 57.95207% with 193 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.03%. Comparing base (fe98a6c) to head (5bb09bd).
⚠️ Report is 15 commits behind head on master.

Files with missing lines	Patch %	Lines
...ats/iceberg/maintainer/IcebergTableMaintainer.java	23.29%	131 Missing and 4 partials ⚠️
...che/amoro/server/table/TableMaintainerMetrics.java	81.57%	41 Missing and 1 partial ⚠️
...zing/maintainer/DefaultTableMaintainerContext.java	0.00%	6 Missing ⚠️
...org/apache/amoro/maintainer/MaintainerMetrics.java	25.00%	6 Missing ⚠️
...pache/amoro/server/table/AbstractTableMetrics.java	0.00%	1 Missing ⚠️
...apache/amoro/server/table/DefaultTableRuntime.java	75.00%	1 Missing ⚠️
...n/src/main/java/org/apache/amoro/TableRuntime.java	0.00%	1 Missing ⚠️
...ache/amoro/maintainer/MaintainerOperationType.java	90.90%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #4045      +/-   ##
============================================
+ Coverage     29.93%   30.03%   +0.10%     
- Complexity     4229     4283      +54     
============================================
  Files           675      679       +4     
  Lines         53990    55072    +1082     
  Branches       6838     6981     +143     
============================================
+ Hits          16161    16541     +380     
- Misses        36636    37312     +676     
- Partials       1193     1219      +26     

Flag	Coverage Δ
core	30.03% <57.95%> (+0.10%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[majin1102]

Thanks for working on this. Left some comments

[github-actions]

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@amoro.apache.org list. Thank you for your contributions.

[czy006]

cc @baiyangtx @xxubai

[czy006]

@j1wonpark Can you help me review code ? This is an improvement to the monitoring abstraction of a multi-lake format.

[j1wonpark]

This private method is no longer called after the refactor (2-param expireSnapshots now calls expireSnapshotsInternal directly). The "backward compatibility with subclasses" comment doesn't apply since it's private. Can be removed.

[j1wonpark]

startTime is written in recordStart() but never read — getValue() only returns value. Looks like a leftover from an earlier design. Can be removed along with recordStart().

[j1wonpark]

autoCreateTags() logic is now inlined into IcebergTableMaintainer, but AutoCreateIcebergTagAction class and its test TestAutoCreateIcebergTagAction are not deleted in this PR. They become dead code after this change. Should be removed.

Also left a design suggestion about this in a separate comment below.

[j1wonpark]

Duration is recorded twice for the same operation — once by MaintainerOperationExecutor (table_maintainer_operation_duration_millis) and once inside this method (table_snapshots_expiration_duration_millis). The two values will differ slightly. Consider using a single source of truth for duration.

Same pattern applies to doExpireData and autoCreateTags.

[j1wonpark]

Thanks for the contribution! I left a few inline comments on dead code and duration recording.

One design suggestion: the tag creation logic from AutoCreateIcebergTagAction is now inlined into IcebergTableMaintainer, which makes the class larger, leaves the original class as dead code, and couples tag creation logic with the maintainer. It might be cleaner to keep AutoCreateIcebergTagAction and extend it to support metrics, keeping the responsibilities decoupled.