Support .txt files in LLMFileAnalysisOperator#70431
Open
ColtenOuO wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LLMFileAnalysisOperatorrejects.txtfiles withLLMFileAnalysisUnsupportedFormatError, but a file with no extensionat all (e.g.
app) is already accepted and treated as plain text via the"log"fallback indetect_file_format(). The more explicitly-named file was the one that failed.This also put
LLMFileAnalysisOperatorout of step with the rest of the provider:DocumentLoaderOperator(this provider's other file-reading operator) already lists.txtas one of its built-in, zero-extra-dependency formats (EXTENSION_BACKEND_MAP: ".txt": "text").example_llamaindex_rag.py,example_llamaindex_hook.py,example_langchain_tool_agent.py) ship.txtfiles as sample input for LLM-related tasks.Changes
"txt"toSUPPORTED_FILE_FORMATS,_TEXT_LIKE_FORMATS, and_GZIP_SUPPORTED_FORMATSinutils/file_analysis.py._render_text_like, already used for.logand extension-less files) handles.txtas-is.