Fail deferred Cloud Composer tasks when the GCP operation errors#70430
Open
SEPURI-SAI-KRISHNA wants to merge 1 commit into
Open
Fail deferred Cloud Composer tasks when the GCP operation errors#70430SEPURI-SAI-KRISHNA wants to merge 1 commit into
SEPURI-SAI-KRISHNA wants to merge 1 commit into
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CloudComposerExecutionTrigger.run()checkedoperation.donebeforeoperation.error, in anif/elif. Per the long-running operation contract, "ifdone==false, neithererrornorresponseis set", and a finished operation hasdone=Truewith exactly one oferrororresponsepopulated.So the two branches were inverted relative to the API:
elif operation.error.messagebranch was only ever reached whiledonewasfalse— the one state whereerroris guaranteed unset, making it dead code;done=Truewitherrorset) broke out of the loop and yieldedoperation_done: True, the success shape.The consequence differs per operator, all three of which defer with this trigger:
execute_completeCloudComposerUpdateEnvironmentOperatoroperation_done, no state checkCloudComposerDeleteEnvironmentOperatorpassCloudComposerCreateEnvironmentOperatorNotFound/wrong-state error rather than the GCP failure reasonThis also made the deferrable path disagree with the synchronous one: with
deferrable=Falsethe operators callhook.wait_for_operation()→operation.result(), which raises on a failed operation.Checking
errorinside thedonebranch fixes all three. The existingraiseis relocated, not new.CloudComposerExecutionTriggerhad no test coverage, so this adds two cases: a finished-with-error operation must raise, and a finished-without-error operation must still yieldoperation_done: True. The first fails without this change; the second guards the new nested condition against over-raising on success.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5) following the guidelines