Fix deadline serialization, repr, and prune edge cases#70421
Open
seanghaeli wants to merge 3 commits into
Open
Fix deadline serialization, repr, and prune edge cases#70421seanghaeli wants to merge 3 commits into
seanghaeli wants to merge 3 commits into
Conversation
Split out of apache#68919 per review: decoder __class_path routing, clear error for missing __class_path, repr guards for severed dagrun and dict-shaped interval, and prune guard for missed deadlines.
boring-cyborg
Bot
added
area:DAG-processing
area:deadline-alerts
seanghaeli
changed the title
seanghaeli
marked this pull request as ready for review
July 25, 2026 00:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #68919 per review. Edge-case fixes in the deadline model and serialization paths:
__class_pathahead ofreference_type(custom references can share a builtin's class name), and a reference with no importable__class_pathraises a clear error instead of aKeyError.__repr__onDeadlineandDeadlineAlertnever raises (guards thedagrunrelationship post-cascade-delete and the dict-shaped interval).prune_deadlinesexcludes missed deadlines so a missed deadline's queued callback is not cascade-deleted.