Compare logs instead of truncating, allow changing object write mode#68304
Open
jvstein wants to merge 1 commit into
Open
Compare logs instead of truncating, allow changing object write mode#68304jvstein wants to merge 1 commit into
jvstein wants to merge 1 commit into
Conversation
boring-cyborg
Bot
added
area:logging
area:providers
provider:amazon
51 tasks
Contributor
|
I solemnly approve this PR 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #67144 to avoid truncating logs for deployments that rely on both local logs (e.g. in a shared volume mount) and the S3 remote logging support.
Instead of truncating the local file, it compares the logs in memory using
startswith.This also introduces a configuration value for modifying the default write mode for object stores. Notably, I believe the Google and Azure object store logging may have a similar memory bug due to a download, append, upload process.
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code following the guidelines