Fix empty labels in Stackdriver log IO for Airflow 3 Supervisor#68292
Open
23tae wants to merge 2 commits into
Open
Fix empty labels in Stackdriver log IO for Airflow 3 Supervisor#6829223tae wants to merge 2 commits into
23tae wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds fallback logic to
StackdriverRemoteLogIOto extract task labels directly from thestructlogcontext dictionary whenrecord.task_instanceis missing, addressing the empty labels issue in the Airflow 3 Supervisor.Description
This PR addresses Bug 1 described in #68240.
In the Airflow 3 Task SDK Supervisor environment, the
task_instanceobject may be stripped from log records. Without it, the Stackdriver handler failed to attach identifying labels, resulting in untraceable "empty label" logs in Google Cloud.As suggested by @ashb in the issue, rather than manually parsing log file paths, this PR leverages the
structlogcontext variables. The Task SDK inherently binds task details to the structlog context, making them naturally available in theeventdictionary.Key changes
StackdriverRemoteLogIO.processors.proc. Ifrecord.task_instanceis missing, it safely extractsdag_id,task_id,run_id,try_number, andmap_indexdirectly from theeventdictionary and applies them as labels.Verification Results
I have verified the changes using
prekandbreeze.related: #68240
Was generative AI tooling used to co-author this PR?
Generated-by: Antigravity following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.