Skip to content

i18n(zh-CN): add missing translations#68289

Merged
Lee-W merged 2 commits into
apache:mainfrom
sjyangkevin:fix/add-ch-zn-missing-translation
Jun 10, 2026
Merged

i18n(zh-CN): add missing translations#68289
Lee-W merged 2 commits into
apache:mainfrom
sjyangkevin:fix/add-ch-zn-missing-translation

Conversation

@sjyangkevin

@sjyangkevin sjyangkevin commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Add missing Simplified Chinese (zh-CN) translations for the Airflow 3.3.0 RC.

breeze ui check-translation-completeness --language zh-CN
Screenshot from 2026-06-09 10-01-39
Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: [Claude Code (Claude Sonnet 4.6)] following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg boring-cyborg Bot added area:translations area:UI Related to UI/UX. For Frontend Developers. translation:zh-CN labels Jun 9, 2026

@Lee-W Lee-W left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Find some usage that surprised me, but after some research, it seems to be right 👀

Welcome back Kevin :)

@sjyangkevin

Copy link
Copy Markdown
Contributor Author

Find some usage that surprised me, but after some research, it seems to be right 👀

Welcome back Kevin :)

Thanks Wei! Interested in which usage is that. I am a bit unsure about "consumingAsset": "消费者资源", but it seems to be aligned with existing convention.

@Lee-W

Lee-W commented Jun 9, 2026

Copy link
Copy Markdown
Member

"告警" haha, we probably would use "警告" but might change it to something else based on the context

@Lee-W

Lee-W commented Jun 9, 2026

Copy link
Copy Markdown
Member

"consumingAsset": "消费者资源" is a hard one 😢 it's correct but not that easy to understand

@sjyangkevin

sjyangkevin commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

"告警" haha, we probably would use "警告" but might change it to something else based on the context

actually good catch! I did a quick check through the current translation, and "警告" is used. Thanks! I just pushed a fix for that

@sjyangkevin sjyangkevin marked this pull request as ready for review June 9, 2026 16:17
@sjyangkevin sjyangkevin requested a review from potiuk as a code owner June 9, 2026 16:17
@sjyangkevin

Copy link
Copy Markdown
Contributor Author

Would appreciate if the translation/code owner could also have a review on this:
@Fortytwoo @gyli

@gyli

gyli commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Good catch for 告警, while I also think 警报 is a more accurate translation, as 警告 means warning instead of alert. However, 警告 is already used in many other zh-CN translations consistently, so I don't think we want to change it in this PR. If we want to discuss this translation and make the change, a separated PR should be raised.

@gyli

gyli commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Others look good to me!

@sjyangkevin

Copy link
Copy Markdown
Contributor Author

Thanks @gyli for the feedback.

@Lee-W

Lee-W commented Jun 10, 2026

Copy link
Copy Markdown
Member

hmmm... google lies to me. it told me 告警 is ok 🤦‍♂️

@Lee-W

Lee-W commented Jun 10, 2026

Copy link
Copy Markdown
Member

cool, gonna merge it now. great to see you both :)

@Lee-W Lee-W merged commit f392484 into apache:main Jun 10, 2026
163 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:translations area:UI Related to UI/UX. For Frontend Developers. translation:zh-CN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants