Batch triggerer unused trigger cleanup deletes#68269
Open
BeauDevCode wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #68243
Why
Trigger.clean_unused()currently removes all unreferenced trigger rows in one unbounded delete. On busy deployments this can hold locks on thetriggertable for the duration of a large cleanup and stall the triggerer loop.What changed
[triggerer] unreferenced_triggers_cleanup_batch_size, defaulting to500; setting it to0keeps single-transaction cleanup behavior.2and verifies five unused triggers are removed across three committed delete batches.Related context: PR #68244 changes the anti-join shape in the same method, but does not add bounded delete batches. This PR intentionally focuses on the batching behavior requested in #68243.
Tests
git diff --checkpython3 -m compileall -q airflow-core/src/airflow/models/trigger.py airflow-core/tests/unit/models/test_trigger.pyairflow-core/src/airflow/config_templates/config.ymlwith PyYAML and verified the new option shapeNot run locally: focused pytest/config validation could not complete because this environment lacks parts of Airflow's development dependency set (
pathspecduring test collection;requestsfordev/validate_version_added_fields_in_config.py).