fix(tests): Use unique S3 bucket name in bedrock evaluation system test#68256
Merged
Merged
Conversation
Include env_id in the bucket name to prevent collisions when the test
runs concurrently (e.g. local run + executor run). The hardcoded
bucket name caused ValueError('The key ... already exists') when two
executions overlapped.
ramitkataria
approved these changes
Jun 8, 2026
vincbeck
approved these changes
Jun 8, 2026
Contributor
Author
|
This actually uncovered a buglett which is fixed in #68310. Three fields are listed as templated byut are not actually passed to templated_fields, which means the new bucket_name which has an embedded env_id wasn't resolving the env_id and passed the jinja template string un-rendered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include env_id in the bucket name to prevent collisions when the test runs concurrently (e.g. local run + executor run). The hardcoded bucket name caused ValueError('The key ... already exists') when two executions overlapped.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.