Skip to content

fix(tests): Use unique S3 bucket name in bedrock evaluation system test#68256

Merged
vincbeck merged 1 commit into
apache:mainfrom
aws-mwaa:ferruzzi/system-tests/bedrock-eval
Jun 9, 2026
Merged

fix(tests): Use unique S3 bucket name in bedrock evaluation system test#68256
vincbeck merged 1 commit into
apache:mainfrom
aws-mwaa:ferruzzi/system-tests/bedrock-eval

Conversation

@ferruzzi

@ferruzzi ferruzzi commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Include env_id in the bucket name to prevent collisions when the test runs concurrently (e.g. local run + executor run). The hardcoded bucket name caused ValueError('The key ... already exists') when two executions overlapped.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

Include env_id in the bucket name to prevent collisions when the test
runs concurrently (e.g. local run + executor run).  The hardcoded
bucket name caused ValueError('The key ... already exists') when two
executions overlapped.
@ferruzzi ferruzzi requested a review from o-nikolas as a code owner June 8, 2026 22:54
@boring-cyborg boring-cyborg Bot added area:providers provider:amazon AWS/Amazon - related issues labels Jun 8, 2026
@vincbeck vincbeck merged commit a11fa2f into apache:main Jun 9, 2026
81 checks passed
@vincbeck vincbeck deleted the ferruzzi/system-tests/bedrock-eval branch June 9, 2026 15:01
@ferruzzi

ferruzzi commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

This actually uncovered a buglett which is fixed in #68310. Three fields are listed as templated byut are not actually passed to templated_fields, which means the new bucket_name which has an embedded env_id wasn't resolving the env_id and passed the jinja template string un-rendered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants