Skip to content

Fix flakiness in AdvisoryViaNetworkTest by verifying peer broker info on both sides of duplex network #1867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gurpartap3697 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

Fix flakiness in AdvisoryViaNetworkTest by verifying peer broker info on both sides of duplex network #1867

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions activemq-unit-tests/src/test/java/org/apache/activemq/usecases/AdvisoryViaNetworkTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ public void testAdvisoryPrefetchSize() throws Exception {

startAllBrokers();
verifyPeerBrokerInfo(brokers.get("A"), 1);
verifyPeerBrokerInfo(brokers.get("B"), 1);

createConsumer("A", topic1);
createConsumer("A", new ActiveMQTopic("A.FOO2"));
Expand Down Expand Up @@ -142,6 +143,7 @@ public void testAdvisoryPrefetchSize1() throws Exception {

startAllBrokers();
verifyPeerBrokerInfo(brokers.get("A"), 1);
verifyPeerBrokerInfo(brokers.get("B"), 1);

createConsumer("A", topic1);
createConsumer("A", new ActiveMQTopic("A.FOO2"));
Expand Down Expand Up @@ -177,6 +179,7 @@ public void testAdvisoryPrefetchSizeNotSet() throws Exception {

startAllBrokers();
verifyPeerBrokerInfo(brokers.get("A"), 1);
verifyPeerBrokerInfo(brokers.get("B"), 1);

createConsumer("A", topic1);
createConsumer("A", new ActiveMQTopic("A.FOO2"));
Expand Down Expand Up @@ -211,6 +214,7 @@ public void testPrefetchSize1() throws Exception {

startAllBrokers();
verifyPeerBrokerInfo(brokers.get("A"), 1);
verifyPeerBrokerInfo(brokers.get("B"), 1);

createConsumer("A", topic1);
createConsumer("A", new ActiveMQTopic("A.FOO2"));
Expand Down Expand Up @@ -243,6 +247,7 @@ public void testAdvisoryPrefetchSizePercent() throws Exception {

startAllBrokers();
verifyPeerBrokerInfo(brokers.get("A"), 1);
verifyPeerBrokerInfo(brokers.get("B"), 1);

for (int i = 0; i < 10; i++) {
createConsumer("A", new ActiveMQTopic("A.FOO"));
Expand Down Expand Up @@ -270,6 +275,7 @@ public void testPrefetchSizePercent() throws Exception {

startAllBrokers();
verifyPeerBrokerInfo(brokers.get("A"), 1);
verifyPeerBrokerInfo(brokers.get("B"), 1);

for (int i = 0; i < 10; i++) {
createConsumer("A", new ActiveMQTopic("A.FOO"));
Expand Down
Loading