-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add VM transport broker restart test #1631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add VM transport broker restart test #1631
Conversation
activemq-unit-tests/src/test/java/org/apache/activemq/VmTransportBrokerRestartTest.java
Show resolved
Hide resolved
jeanouii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, is this test because you have seen some weird behavior or because you faced issues with the VM transport?
Nothing critical, but FYI there are discussions to get rid of Spring, so it'd be nice to use Plain JMS APIs instead of JmsTemplate to ease future work to remove Spring. It's probably not of a big value here, so maybe something you can do. Again, not critical.
activemq-unit-tests/src/test/java/org/apache/activemq/VmTransportBrokerRestartTest.java
Show resolved
Hide resolved
67e0a6e to
77eb289
Compare
jeanouii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing the small feedback.
jbonofre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the test.
nit: as this test is "squared" on vm, it would have make sense to add the test in the activemq-broker module (instead of activemq-unit-tests).
But that's a detail, and we can move it later.
|
I just ran the CI. I will merge as soon as green. |
This PR adds a unit test to validate VM transport behaviour when the broker
is stopped and restarted.
The test ensures:
Test passes when run in IDE and follows existing ActiveMQ unit test patterns.