AMQ-9845 Fix race condition in AMQ4889Test

[jeanouii]

by ensuring proper connection handling and verification of successful and failed connections

[cshannon]

Is there a Jira for this or a more general Jira for test issues? I know we generally create Jiras for everything. At some point we should be moving to Github issues and at that point maybe we don't really need to worry about it because github PRs are self documenting anyways.

Also I think we need to set up github actions to publish test failures, it's very hard right now to see what tests actually failed. Our jenkins setup used to do that and it was easy ot see the tests that failed.

[jeanouii]

I don't think there is @cshannon when there is an associated bug I always create a JIRA, but not always for every single test I fix. There is only one in this PR, I can start creating JIRA issues for all tests I fix from now on.
Totally fine with me

[jeanouii]

Failed because of

[INFO] Results:
[INFO] 
Error:  Errors: 
Error:    AdvisoryBrokerTest>CombinationTestSupport.runBare:107->testConsumerAdvisoriesReplayed:175 ClassCast class org.apache.activemq.command.ConsumerInfo cannot be cast to class org.apache.activemq.command.RemoveInfo (org.apache.activemq.command.ConsumerInfo and org.apache.activemq.command.RemoveInfo are in unnamed module of loader 'app')
Error:    VirtualTopicsAndDurableSubsTest>CombinationTestSupport.runBare:113->CombinationTestSupport.runBare:107->MBeanTest.testQueuePauseResume:1823 » ConnectionFailed The JMS connection has failed: Estimated allocated buffer size of 308 bytes is larger than frame size of 154 bytes
[INFO] 
Error:  Tests run: 1506, Failures: 0, Errors: 2, Skipped: 153

The flaky tests have been addressed in PR #1634