Moved About modal to overview page#6366
Conversation
Moved the information in the About model page to the overview page. Increased the font size on the overview table. Closes apache#6365
|
Need to figure out how to add a loading spinner to instance information card and fix the vertical alignment in the deployment overview table. |
|
I backed out the changes to try and make the deployment table contents larger. Created #6368 to try and fix it in a different issue. Current screen shot of the changes in this PR:
|
…resources/js/overview.js Co-authored-by: Dom G. <domgarguilo@apache.org>
|
I'm very strongly -1 for moving this "About" information to the main overview page, just to make it less light on content. I don't think we need to try to fill the space just to fill it, and I think the About page is better to have off to the side. I would prefer model stay, but the preferences be added to it. It's nice to have a modal preferences window, and the information in the About modal can be shown there. It doesn't need to be added to the Overview page. I'm in favor of reverting this, or moving it back to a modal for the preferences. |
It wasn't moved solely because the overview page was light on content. The suggestion was made to change the three-dot menu icon to a gear icon and make it a preferences menu. It didn't make sense to me to have the About menu item in the preference menu. What I have seen in most UIs is that the About page is located off some Help menu (Help -> About).
I feel like that is odd, I don't know that I have ever seen an implementation of this.
I can revert this change and move the About back to the three-dot menu. In PR #6369 the About link will show up in the preference menu. |
This is a follow-on to apache#6366 that changes the three-dot menu icon to a gear and moves the message priority and message category switches from the messages page to the preference / settings menu. Related to apache#6365
I agree, but I was thinking that instead of having preferences be a menu, it could be a modal, with the about details inside that model (not as a separate link), to consolidate the two.
Same, but we don't have a general help, so we need to do something a little different.
My idea is roughly modeled after other "settings" pages that I've seen that have some system details alongside some system options. This is common for many UIs:
So, we can certainly do something similar, having some basic static state (information about the system) alongside preferences inputs. I was thinking a simple modal, something like the following outline: |
|
This was reverted in 515a7f1 |


Moved the information in the About model page
to the overview page.
Closes #6365