Skip to content

Moved About modal to overview page#6366

Merged
dlmarion merged 4 commits into
apache:mainfrom
dlmarion:6365-move-instance-info
May 13, 2026
Merged

Moved About modal to overview page#6366
dlmarion merged 4 commits into
apache:mainfrom
dlmarion:6365-move-instance-info

Conversation

@dlmarion
Copy link
Copy Markdown
Contributor

@dlmarion dlmarion commented May 11, 2026

Moved the information in the About model page
to the overview page.

Closes #6365

Moved the information in the About model page
to the overview page. Increased the font size
on the overview table.

Closes apache#6365
@dlmarion dlmarion added this to the 4.0.0 milestone May 11, 2026
@dlmarion dlmarion self-assigned this May 11, 2026
@dlmarion
Copy link
Copy Markdown
Contributor Author

Need to figure out how to add a loading spinner to instance information card and fix the vertical alignment in the deployment overview table.

@dlmarion
Copy link
Copy Markdown
Contributor Author

Look at the overview page with the instance card. I made the overview table font size larger in a prior commit and now the vertical alignment of the numbers in the pills is off.

InstanceCard

@dlmarion dlmarion marked this pull request as ready for review May 13, 2026 13:52
@dlmarion dlmarion requested a review from DomGarguilo May 13, 2026 13:52
@dlmarion
Copy link
Copy Markdown
Contributor Author

I backed out the changes to try and make the deployment table contents larger. Created #6368 to try and fix it in a different issue. Current screen shot of the changes in this PR:

InstanceCard2

…resources/js/overview.js

Co-authored-by: Dom G. <domgarguilo@apache.org>
@dlmarion dlmarion merged commit e5c8482 into apache:main May 13, 2026
4 checks passed
@dlmarion dlmarion deleted the 6365-move-instance-info branch May 13, 2026 17:43
@ctubbsii
Copy link
Copy Markdown
Member

I'm very strongly -1 for moving this "About" information to the main overview page, just to make it less light on content. I don't think we need to try to fill the space just to fill it, and I think the About page is better to have off to the side. I would prefer model stay, but the preferences be added to it. It's nice to have a modal preferences window, and the information in the About modal can be shown there. It doesn't need to be added to the Overview page. I'm in favor of reverting this, or moving it back to a modal for the preferences.

@dlmarion
Copy link
Copy Markdown
Contributor Author

I'm very strongly -1 for moving this "About" information to the main overview page, just to make it less light on content. I don't think we need to try to fill the space just to fill it, and I think the About page is better to have off to the side.

It wasn't moved solely because the overview page was light on content. The suggestion was made to change the three-dot menu icon to a gear icon and make it a preferences menu. It didn't make sense to me to have the About menu item in the preference menu. What I have seen in most UIs is that the About page is located off some Help menu (Help -> About).

I would prefer model stay, but the preferences be added to it.

I feel like that is odd, I don't know that I have ever seen an implementation of this.

It's nice to have a modal preferences window, and the information in the About modal can be shown there. It doesn't need to be added to the Overview page. I'm in favor of reverting this, or moving it back to a modal for the preferences.

I can revert this change and move the About back to the three-dot menu. In PR #6369 the About link will show up in the preference menu.

dlmarion added a commit that referenced this pull request May 14, 2026
dlmarion added a commit to dlmarion/accumulo that referenced this pull request May 14, 2026
This is a follow-on to apache#6366 that changes the three-dot menu
icon to a gear and moves the message priority and message
category switches from the messages page to the preference /
settings menu.

Related to apache#6365
@ctubbsii
Copy link
Copy Markdown
Member

It didn't make sense to me to have the About menu item in the preference menu.

I agree, but I was thinking that instead of having preferences be a menu, it could be a modal, with the about details inside that model (not as a separate link), to consolidate the two.

What I have seen in most UIs is that the About page is located off some Help menu (Help -> About).

Same, but we don't have a general help, so we need to do something a little different.

I would prefer model stay, but the preferences be added to it.

I feel like that is odd, I don't know that I have ever seen an implementation of this.

My idea is roughly modeled after other "settings" pages that I've seen that have some system details alongside some system options. This is common for many UIs:

  • system BIOS menus
  • Windows' "About" app also displays system details and system specifications intermixed with options (like changing the hostname or configuring the activation/license/owner details)
  • RHEL has a similar "About" page in its settings app that shows static info alongside some configurable preferences
  • some GitHub pages, like https://github.com/organizations/<org>/settings/packages have settings alongside state information (in this example, the settings are package permissions, while the state is a list of deleted packages)
  • The GNOME Shell Calendar/Notification UI, which shows static (and navigable) calendar and notifications info, but also has preferences like a "Do Not Disturb" toggle.
  • The modal window for creating a new issue in GitHub has the input areas, but also has static informational links at the bottom to the target repo's contributor guide, security policy, and code of conduct.

So, we can certainly do something similar, having some basic static state (information about the system) alongside preferences inputs.

I was thinking a simple modal, something like the following outline:

----------------- About --------------------
Instance Id: xxxxxxx          Version: 1.2.3
ZooKeepers: host1:port,...
-------------- Preferences -----------------
Option 1: [ ]              Option 2: [x]
Option 3: [x]              Option 4: [x]

@ctubbsii ctubbsii removed this from the 4.0.0 milestone May 14, 2026
@ctubbsii
Copy link
Copy Markdown
Member

This was reverted in 515a7f1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prepare for Preference Menu, move About to Overview

3 participants