Skip to content

Add a loading indicator to empty tables#6338

Open
dlmarion wants to merge 1 commit intoapache:mainfrom
dlmarion:monitor-loading-spinner
Open

Add a loading indicator to empty tables#6338
dlmarion wants to merge 1 commit intoapache:mainfrom
dlmarion:monitor-loading-spinner

Conversation

@dlmarion
Copy link
Copy Markdown
Contributor

This change adds a single column with an empty header row and a loading indicator to the tables that are managed by the server_process_common.js file. The logic in the server_process_common.js file will remove the thead and tbody elements from the table before populating it with columns and rows.

This change adds a single column with an empty header row
and a loading indicator to the tables that are managed
by the server_process_common.js file. The logic in the
server_process_common.js file will remove the thead and
tbody elements from the table before populating it with
columns and rows.
@dlmarion dlmarion added this to the 4.0.0 milestone Apr 24, 2026
@dlmarion dlmarion self-assigned this Apr 24, 2026
@dlmarion dlmarion requested a review from DomGarguilo April 24, 2026 19:56
Copy link
Copy Markdown
Member

@DomGarguilo DomGarguilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things seem to work well here and do the intended job:

image

The only things I can think of that are just preference are:

  1. could refactor this spinner html block into its own file then replace the repeated code with something like <#include "table_loading.ftl">
  2. The spinner and the "Loading..." text are far apart and might look better next to one another. Might be able to do that by replacing the ms-auto with gap-2 or something.

Putting this loading view into a "fake" table seems a bit hacky but seems to work well and looks fine so I don't think its an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants