Add a loading indicator to empty tables#6338
Open
dlmarion wants to merge 1 commit intoapache:mainfrom
Open
Conversation
This change adds a single column with an empty header row and a loading indicator to the tables that are managed by the server_process_common.js file. The logic in the server_process_common.js file will remove the thead and tbody elements from the table before populating it with columns and rows.
DomGarguilo
approved these changes
May 5, 2026
Member
DomGarguilo
left a comment
There was a problem hiding this comment.
Things seem to work well here and do the intended job:
The only things I can think of that are just preference are:
- could refactor this spinner html block into its own file then replace the repeated code with something like
<#include "table_loading.ftl"> - The spinner and the "Loading..." text are far apart and might look better next to one another. Might be able to do that by replacing the
ms-autowithgap-2or something.
Putting this loading view into a "fake" table seems a bit hacky but seems to work well and looks fine so I don't think its an issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a single column with an empty header row and a loading indicator to the tables that are managed by the server_process_common.js file. The logic in the server_process_common.js file will remove the thead and tbody elements from the table before populating it with columns and rows.