Use icons for ScanServer Monitor low mem and idle display#6220
Open
DomGarguilo wants to merge 3 commits intoapache:mainfrom
Open
Use icons for ScanServer Monitor low mem and idle display#6220DomGarguilo wants to merge 3 commits intoapache:mainfrom
DomGarguilo wants to merge 3 commits intoapache:mainfrom
Conversation
Contributor
|
No issues here with the changes. All of the server types should be reporting these metrics (idle, low mem), so I'm not sure if the code changes should be in a more central place or not. |
Member
Author
Could move things. The sserver page is the only place in the monitor where either of these is displayed at the moment. I think if we want to add those data points to other pages that is reasonable and in that case I think its a good idea to centralize this logic. |
dlmarion
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6184
This PR adds icons in place of
1and0in the ScanServer table in the Monitor UI. I also updated the title for these columns to better match this new display:low mem->Memory Stateidle-Activity StateI was not able to trigger the low memory manually but this icon will be present in color

warn(yellow) when that value indicates low mem:https://icons.getbootstrap.com/icons/exclamation-triangle-fill/
I am open to other ideas for which icons to use if anyone has a preference. These were the ones that made sense to me but might not be the best fit.