Skip to content

sets exit code when admin check fails #6079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keith-turner merged 1 commit into from
Jan 28, 2026
+13 −4
Merged

sets exit code when admin check fails #6079

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions server/base/src/main/java/org/apache/accumulo/server/util/Admin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,7 @@ public void execute(final String[] args) {
ServiceStatusCmd ssc = new ServiceStatusCmd();
ssc.execute(context, serviceStatusCommandOpts.json, serviceStatusCommandOpts.showHosts);
} else if (cl.getParsedCommand().equals("check")) {
executeCheckCommand(context, checkCommand, opts);
rc = executeCheckCommand(context, checkCommand, opts);
} else if (cl.getParsedCommand().equals("stopManager")
|| cl.getParsedCommand().equals("stopAll")) {
boolean everything = cl.getParsedCommand().equals("stopAll");
Expand Down Expand Up @@ -1372,7 +1372,7 @@ private static void getAllFateIds(TabletMetadata tabletMetadata,
}

@VisibleForTesting
public static void executeCheckCommand(ServerContext context, CheckCommand cmd,
public static int executeCheckCommand(ServerContext context, CheckCommand cmd,
ServerUtilOpts opts) throws Exception {
validateAndTransformCheckCommand(cmd);

Expand All @@ -1381,8 +1381,10 @@ public static void executeCheckCommand(ServerContext context, CheckCommand cmd,
} else if (cmd.run) {
var givenChecks = cmd.checks.stream()
.map(name -> CheckCommand.Check.valueOf(name.toUpperCase())).collect(Collectors.toList());
executeRunCheckCommand(cmd, givenChecks, context, opts);
return executeRunCheckCommand(cmd, givenChecks, context, opts);
}

return 0;
}

private static void validateAndTransformCheckCommand(CheckCommand cmd) {
Expand Down Expand Up @@ -1423,7 +1425,7 @@ private static void listChecks() {
System.out.println();
}

private static void executeRunCheckCommand(CheckCommand cmd, List<CheckCommand.Check> givenChecks,
private static int executeRunCheckCommand(CheckCommand cmd, List<CheckCommand.Check> givenChecks,
ServerContext context, ServerUtilOpts opts) throws Exception {
// Get all the checks in the order they are declared in the enum
final var allChecks = CheckCommand.Check.values();
Expand All @@ -1442,6 +1444,13 @@ private static void executeRunCheckCommand(CheckCommand cmd, List<CheckCommand.C
}

printChecksResults(checkStatus);

if (checkStatus.values().stream()
.anyMatch(status -> status == CheckCommand.CheckStatus.FAILED)) {
return 5;
} else {
return 0;
}
}

private static boolean depsFailed(CheckCommand.Check check,
Expand Down