Skip to content

feat: [performance improvement] #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anyulled wants to merge 1 commit into from
Closed

feat: [performance improvement] #375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .jules/bolt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,8 @@

**Learning:** Using `Object.entries(obj).find(([key]) => key === target)` creates O(N) array allocations for the entries and traverses them linearly just to do a simple property lookup. This adds unnecessary memory allocation overhead and Garbage Collection.
**Action:** Use direct property lookup instead: `Object.prototype.hasOwnProperty.call(obj, target) ? obj[target as keyof typeof obj] : undefined`. This maintains O(1) performance while satisfying `security/detect-object-injection` linting rules.

## 2026-08-09 - Avoid array.flatMap().find() for early breakout

**Learning:** To prevent memory bloat and O(N) full array traversals during data-heavy operations, avoid the `array.flatMap(mapFn).find(findFn)` pattern.
**Action:** Use nested `for...of` loops or `.some()` with a state object to enable single-pass execution with early breakout.
28 changes: 16 additions & 12 deletions app/[year]/tags/[tag]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,12 @@ export async function generateStaticParams() {
for (const year of years) {
try {
const sessionGroups = await getTalks(year);
const allTalks = sessionGroups.flatMap((group) => group.sessions);
const allTags = new Set<string>();

for (const talk of allTalks) {
getTagsFromTalk(talk).forEach((tag) => allTags.add(tag));
for (const group of sessionGroups) {
group.sessions.forEach((talk) => {
getTagsFromTalk(talk).forEach((tag) => allTags.add(tag));
});
}

for (const tag of allTags) {
Expand All @@ -46,9 +47,11 @@ export async function generateMetadata({ params }: Readonly<TagPageProps>): Prom
const decodedTag = decodeURIComponent(tag);

const sessionGroups = await getTalks(year);
const allTalks = sessionGroups.flatMap((group) => group.sessions);
const searchTag = decodedTag.toLowerCase();
const matchingTalk = allTalks.find((talk) => getTagsFromTalk(talk).some((t) => t.replaceAll(" ", "-").toLowerCase() === searchTag));
const matchingGroup = sessionGroups.find((group) =>
group.sessions.some((talk) => getTagsFromTalk(talk).some((t) => t.replaceAll(" ", "-").toLowerCase() === searchTag))
);
const matchingTalk = matchingGroup?.sessions.find((talk) => getTagsFromTalk(talk).some((t) => t.replaceAll(" ", "-").toLowerCase() === searchTag));
const displayTag = matchingTalk
? (getTagsFromTalk(matchingTalk).find((t) => t.replaceAll(" ", "-").toLowerCase() === searchTag) ?? decodedTag.replaceAll("-", " "))
: decodedTag.replaceAll("-", " ");
Expand All @@ -65,15 +68,16 @@ export default async function TagPage({ params }: Readonly<TagPageProps>) {
const eventData = getEditionConfig(year);

const sessionGroups = await getTalks(year);
const allTalks = sessionGroups.flatMap((group) => group.sessions);

const searchTag = decodedTag.toLowerCase();
const filteredTalks: import("@/hooks/types").Talk[] = [];

const filteredTalks = allTalks.filter((talk) => {
const talkTags = getTagsFromTalk(talk);

return talkTags.some((t) => t.replaceAll(" ", "-").toLowerCase() === searchTag);
});
for (const group of sessionGroups) {
group.sessions.forEach((talk) => {
if (getTagsFromTalk(talk).some((t) => t.replaceAll(" ", "-").toLowerCase() === searchTag)) {
filteredTalks.push(talk);
}
});
}

const displayTag = filteredTalks[0]
? (getTagsFromTalk(filteredTalks[0]).find((t) => t.replaceAll(" ", "-").toLowerCase() === searchTag) ?? decodedTag.replaceAll("-", " "))
Expand Down
Loading