Skip to content

Use fallback eventnames if not set#9

Merged
shftlvch merged 4 commits intomainfrom
use-fallback-eventnames-if-not-set
Mar 26, 2026
Merged

Use fallback eventnames if not set#9
shftlvch merged 4 commits intomainfrom
use-fallback-eventnames-if-not-set

Conversation

@JeDaVard
Copy link
Copy Markdown
Collaborator

No description provided.

@opencode-agent
Copy link
Copy Markdown
Contributor

No actual correctness, regression, or security issues stood out in the changed lines.

Residual risk:

  • These changes only affect live WooCommerce tracking paths (add_to_cart, checkout, product view, purchase, and checkout AJAX), and this PR does not show any realistic validation of those flows. Manual smoke testing in a local WooCommerce install is still the main gap here, especially for older installs where waap_options is missing these keys.

New%20session%20-%202026-03-26T10%3A42%3A27.562Z
opencode session  |  github run

@opencode-agent
Copy link
Copy Markdown
Contributor

No actual findings in the diff.

Residual risk:

  • This changes live WooCommerce tracking behavior for ViewContent, AddToCart, InitiateCheckout, AddPaymentInfo, and Purchase when waap_options is missing those keys, but the PR does not show any validation of those storefront flows. The main remaining check is a manual smoke test on an upgraded site with an existing waap_options row missing one or more of these keys, plus a quick php -l on the changed PHP files.

New%20session%20-%202026-03-26T10%3A44%3A51.704Z
opencode session  |  github run

@opencode-agent
Copy link
Copy Markdown
Contributor

No actual findings in the diff.

Residual risk:

  • This changes live WooCommerce tracking behavior for ViewContent, AddToCart, InitiateCheckout, AddPaymentInfo, and Purchase when those waap_options keys are missing, but the PR does not show realistic validation of those storefront flows. Main remaining check is a narrow manual smoke test on an upgraded site where waap_options lacks one or more of these keys, plus php -l on the changed PHP files.

New%20session%20-%202026-03-26T10%3A46%3A15.054Z
opencode session  |  github run

@shftlvch shftlvch merged commit 49aaa73 into main Mar 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants