fix: remove plt.close() from show(), expose get_figure() and get_axes()#787
Open
katerinakzmn wants to merge 2 commits into
Open
fix: remove plt.close() from show(), expose get_figure() and get_axes()#787katerinakzmn wants to merge 2 commits into
katerinakzmn wants to merge 2 commits into
Conversation
Fixes anyoptimization#771. Previously, calling .show() would call plt.close() immediately after plt.show(), destroying the figure and making it impossible to: - further customise the plot (add titles, annotations, change limits) - save it again with different settings - access the figure/axes objects for downstream use Changes: - Remove the bare plt.close() call from Plot.show() - Add Plot.get_figure() -> matplotlib.figure.Figure - Add Plot.get_axes() -> matplotlib.axes.Axes (or ndarray) - Clarify close_on_destroy comment: users can set it to False to keep the figure alive after the Plot object is garbage-collected Users who relied on plt.close() being called automatically can close explicitly after they are done: plot.show() plt.close(plot.fig)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #771.
Previously, calling .show() would call plt.close() immediately after plt.show(), destroying the figure and making it impossible to:
Changes:
the figure alive after the Plot object is garbage-collected
Users who relied on plt.close() being called automatically can close explicitly after they are done:
plot.show()
plt.close(plot.fig)