fix(hookify): support phase-qualified events, absolute paths, and NotebookEdit#42944
Open
Tarun-joy wants to merge 1 commit intoanthropics:mainfrom
Open
fix(hookify): support phase-qualified events, absolute paths, and NotebookEdit#42944Tarun-joy wants to merge 1 commit intoanthropics:mainfrom
Tarun-joy wants to merge 1 commit intoanthropics:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pre-file,post-file,pre-bash,post-bash) being silently dropped due to exact string matching inconfig_loader.pyCLAUDE_PROJECT_DIRenv var for rule file discovery instead of relative paths (fixes breakage in worktrees and subagents)NotebookEditto file event tool matching inpretooluse.pyandposttooluse.pyProblem
Rules with
event: post-filenever fire becauseconfig_loader.py:221compares'post-file' != 'file'and filters them out. Users get no error — rules are silently ignored. This affects any hookify user who uses phase-qualified events.Similarly,
load_rules()usesos.path.join('.claude', 'hookify.*.local.md')which fails when the hook runs from a non-project-root working directory (common in worktrees and subagent contexts).Changes
config_loader.py: Addedphaseparameter toload_rules(), parse phase prefix from event strings, useCLAUDE_PROJECT_DIRfor absolute pathspretooluse.py: Passphase='pre', addNotebookEditto file event tools, fix import pathposttooluse.py: Passphase='post', addNotebookEditto file event tools, fix import pathTest
Create
.claude/hookify.test.local.md:Edit any
.tsfile — the message should appear after the edit completes.