Skip to content

fix(_models): guard against IndexError in construct_type for bare list #1627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devteamaegis wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Open

fix(_models): guard against IndexError in construct_type for bare list #1627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/anthropic/_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,7 +668,7 @@ def construct_type(*, value: object, type_: object, metadata: Optional[List[Any]
if not is_list(value):
return value

inner_type = args[0] # List[inner_type]
inner_type = args[0] if args else object # List[inner_type] or bare list
return [construct_type(value=entry, type_=inner_type) for entry in value]

if origin == float:
Expand Down
7 changes: 6 additions & 1 deletion tests/test_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1014,4 +1014,9 @@ class Model(BaseModel):

# falls back to list of chars rather than calling str(["h", "e", "l", "l", "o"])
assert m.data["items"] == ["h", "e", "l", "l", "o"]
assert m.model_dump()["data"]["items"] == ["h", "e", "l", "l", "o"]


def test_construct_type_bare_list() -> None:
# Bare list (no type parameter) must not raise IndexError
result = construct_type(value=["a", "b", "c"], type_=list)
assert result == ["a", "b", "c"]