fix(docs): correct BetaAsyncAbstractMemoryTool docstring for async usage#1307
Open
abdelhadi703 wants to merge 1 commit intoanthropics:mainfrom
Open
fix(docs): correct BetaAsyncAbstractMemoryTool docstring for async usage#1307abdelhadi703 wants to merge 1 commit intoanthropics:mainfrom
abdelhadi703 wants to merge 1 commit intoanthropics:mainfrom
Conversation
The docstring example for BetaAsyncAbstractMemoryTool was copy-pasted from the synchronous BetaAbstractMemoryTool class without being updated for async usage, causing TypeError when following the example verbatim. Changes: - Use BetaAsyncAbstractMemoryTool as base class (was BetaAbstractMemoryTool) - Use async def for method definitions (was sync def) - Use AsyncAnthropic client (was Anthropic) - Add await to the run_tools call Fixes anthropics#1290 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The docstring example for
BetaAsyncAbstractMemoryToolwas copy-pasted from the synchronousBetaAbstractMemoryToolclass without being updated for async usage, causingTypeErrorwhen following the example verbatim.Bug Details
Three errors in the docstring example:
BetaAbstractMemoryTool(sync) → should beBetaAsyncAbstractMemoryTooldef view(...)→ should beasync def view(...)Anthropic()→ should beAsyncAnthropic()Changes
BetaAsyncAbstractMemoryToolas base classasync deffor method definitionsAsyncAnthropicclientawaitto therun_toolscallTesting
The corrected example now works:
Fixes #1290