Conversation
Gobot1234
requested review from
hpohekar,
mayankansys,
mkundu1,
prmukherj and
seanpearsonuk
as code owners
There was a problem hiding this comment.
Pull request overview
This PR adds test coverage for arbitrary sequence classes in the settings API, specifically testing the ability to use sequence-like objects (such as UserList) when copying boundary conditions.
Changes:
- Added a new test function
test_sequence_attributesto verify that sequence types work correctly with the settings API'scopymethod - Added imports for
UserListandSolverto support the new test
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-actions
bot
added
the
maintenance
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1 @@ | |||
| Add test for sequence | |||
There was a problem hiding this comment.
The changelog entry 'Add test for sequence' is too vague. It should be more descriptive, such as 'Add test for boundary condition copy accepting arbitrary sequence types' to clearly indicate what functionality is being tested.
| Add test for sequence | |
| Add test for boundary condition copy accepting arbitrary sequence types |
|
Failures look unrelated |
5 participants
Context
There were no tests for abitary sequence classes in the settings api
Change Summary
Add a test for it
Impact
Just tests