Never ever put a task in a retired workers queue#16213
Closed
AlanCoding wants to merge 2 commits intoansible:develfrom
Closed
Never ever put a task in a retired workers queue#16213AlanCoding wants to merge 2 commits intoansible:develfrom
AlanCoding wants to merge 2 commits intoansible:develfrom
Conversation
AlanCoding
force-pushed
the
retired_means_retired
branch
from
c15e18e to
ed4985f
Compare
Member
Author
|
not serious enough to keep around |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
We had a few problems with the accuracy of logs related to retired workers that this intends to address, but it really came from a stuck task.
Also, the path for retiring a worker is complicated if it gets additional items in its queue, so this just gives up on placing a task if all workers are retired.
ISSUE TYPE
COMPONENT NAME