AAP-58539 Move to dispatcherd

[thedoubl3j]

SUMMARY

Removing the dispatcher feature flag as well as migrating anything that might be needed to new dispatcherd library.

PR is still a WIP and not finished. If you see anything or think of anything please note it.

ISSUE TYPE

• Breaking Change

COMPONENT NAME

• API

ADDITIONAL INFORMATION

[AlanCoding]

Looking like it's making good progress. Next I would like to try to focus on the decorator transition

awx/awx/main/scheduler/tasks.py

Line 10 in d7eb714

from awx.main.dispatch.publish import task as task_awx

Should be something that can be replaced now with the @task decorator directly from the dispatcherd library, and this will make obvious a lot of cascading deletions from there.

[AlanCoding]

from checks

  File "/awx_devel/awx/main/tasks/system.py", line 625, in <module>
    @task(queue=get_task_queuename, bind_kwargs=['dispatch_time', 'worker_tasks'])
     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: task() got an unexpected keyword argument 'bind_kwargs'
make[1]: *** [Makefile:344: test] Error 1

The bind_kwargs was from the old system and shouldn't be used anymore.

[thedoubl3j]

#16209 (comment) I think this was coming from the old heartbeat function and is removed now.

[thedoubl3j]

awx/main/dispatch/worker/__init__.py:3: in <module>
    from .task import TaskWorker  # noqa
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E   ImportError: cannot import name 'TaskWorker' from 'awx.main.dispatch.worker.task' (/awx_devel/awx/main/dispatch/worker/task.py)

this feels stale because that import no longer exists

[AlanCoding]

If you have problems with the linters you might need to rebase to get #16232

also likely related to the code conflicts.

[AlanCoding]

Because the publish.py module was removed, it looks like DISPATCHER_MOCK_PUBLISH setting should be removed from all the other places. Just doing a find-all should discover all the locations that need lines deleted.

[AlanCoding]

Next up, we see in server logs, via artifacts of the test run:

  File "/awx_devel/awx/main/dispatch/pool.py", line 73, in up
    logger.debug('scaling up worker pid:{}'.format(worker.pid))
                                                   ^^^^^^^^^^
AttributeError: 'PoolWorker' object has no attribute 'pid'

The pid method was removed, and I suggest just putting in worker.process.pid in favor of what's there. This prevents callback receiver from starting up which causes the failures.

[sonarqubecloud]

Quality Gate failed

Failed conditions
43.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud