4.5.1.3 not idempotent#514
Merged
uk-bolly merged 2 commits intoansible-lockdown:develfrom Jan 22, 2026
Merged
Conversation
Signed-off-by: bol7742 <102948121+bol7742@users.noreply.github.com>
|
Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown! |
frederickw082922
requested changes
Dec 23, 2025
Contributor
frederickw082922
left a comment
frederickw082922
left a comment
There was a problem hiding this comment.
Thank you for your PR. However @bol7742 , it fails at run.
Signed-off-by: bol7742 <102948121+bol7742@users.noreply.github.com>
Contributor
Author
|
Hi Frederick, sorry for the error, I just fixed it ! Thanks |
uk-bolly
requested review from
frederickw082922
and removed request for
frederickw082922
frederickw082922
approved these changes
Jan 22, 2026
Contributor
frederickw082922
left a comment
frederickw082922
left a comment
There was a problem hiding this comment.
Thank you @bol7742
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overall Review of Changes:
"4.5.1.3 | AUDIT | Ensure password expiration warning days is 7 or more | capture users not matching"currently capture all users with password, instead of only users with expiration warning delay lower than expected.Therefore
"4.5.1.3 | PATCH | Ensure password expiration warning days is 7 or more | change users not matching req"is executed on already compliant users.This fix update
"4.5.1.3 | AUDIT | Ensure password expiration warning days is 7 or more | capture users not matching"to capture only not compliant users, like in RHEL9-CIS ( https://github.com/ansible-lockdown/RHEL9-CIS/blob/devel/tasks/section_5/cis_5.4.1.x.yml#L87 )