Added TAG_PREFIX so more descriptive tags can be used#326
Added TAG_PREFIX so more descriptive tags can be used#326anothrNick merged 4 commits intoanothrNick:masterfrom
Conversation
|
@anothrNick When you get a chance can you take a look at this one please |
|
Hi @anothrNick , this feature would be great for working with monorepos. |
README.md
Outdated
| - **DEFAULT_BUMP** _(optional)_ - Which type of bump to use when none explicitly provided (default: `minor`). | ||
| - **DEFAULT_BRANCH** _(optional)_ - Overwrite the default branch its read from GitHub Runner env var but can be overwritten (default: `$GITHUB_BASE_REF`). Strongly recommended to set this var if using anything else than master or main as default branch otherwise in combination with history full will error. | ||
| - **WITH_V** _(optional)_ - Tag version with `v` character. | ||
| - **WITH_V** _(optional, depricated)_ - Tag version with `v` character. Replaced by TAG_PREFIX |
There was a problem hiding this comment.
| - **WITH_V** _(optional, depricated)_ - Tag version with `v` character. Replaced by TAG_PREFIX | |
| - **WITH_V** _(optional, deprecated)_ - Tag version with `v` character. Replaced by TAG_PREFIX |
There was a problem hiding this comment.
@robw-raviga Thanks. Fixed in ed6507f
|
Any chance this can get merged? It's the only thing holding our team up from using this in our monorepo. |
|
@timothyclarke @yannickpoggel @dethell Approved. I will merge and deploy. |
|
Should be available in |
|
@anothrNick and @timothyclarke It seems like this PR is causing 2 In this case the tag |
| else | ||
| new="$new-$suffix.0" | ||
| fi | ||
| new="${tagPrefix}${new}-${suffix}.0" |
There was a problem hiding this comment.
This is where the bug comes in. ${new} already has the tag prefix.
Summary of changes
Added
TAG_PREFIXto replaceWITH_V.WITH_Vis still in place for backwards comparability, but the idea is it would be removed in a few versions (gives people a chance to change their code, doesn't force a major etc)This should fix #320. I have a similar use case where a monorepo has a bunch of folders which maintain independent versions
This is best used along side changed-files and a matrix
Breaking Changes
Do any of the included changes break current behaviour or configuration?
NO : The changes are backwards compatible to allow a smoother transition
How changes have been tested
Backwards compatibility
tagging WITH_V false
tagging WITH_V true
New Feature (all in matrix jobs as that's my usecase)
Bump multiple tags
Bump one tag add one tag
List any unknowns