refactor(core): replace deferred tool option with codemode#36560
Open
rekram1-node wants to merge 4 commits into
Open
refactor(core): replace deferred tool option with codemode#36560rekram1-node wants to merge 4 commits into
rekram1-node wants to merge 4 commits into
Conversation
Tools default into CodeMode; set codemode: false for native provider tools. Built-ins opt out; MCP follows CODEMODE_ENABLED. Adds the V2 CodeMode catalog design handoff for the stacked follow-ups.
2 tasks
codemode now defaults true, so native-facing promise tests must opt out.
Use options.codemode for Promise plugin tests, drop local-only design handoff from the branch, and remove packages/codemode/codemode.md.
Resolve modify/delete conflict by keeping packages/codemode/codemode.md removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deferred→codemode(defaults true = enter CodeMode)codemode: falsekeeps tools on the provider native list; built-ins opt outcodemode: Flag.CODEMODE_ENABLEDspecs/v2/codemode.mddesign handoff for the stacked PR seriesPart of #36196
Stack
deferred→codemodenamespace/pinnedfieldsTest plan
bun typecheckinpackages/coreandpackages/pluginbun test test/session-runner-tool-registry.test.ts test/plugin.test.tsinpackages/corebun test test/tool-read.test.ts test/tool-edit.test.ts test/tool-write.test.ts test/mcp.test.tsinpackages/coreNote: pre-push monorepo typecheck fails on pre-existing
@opencode-ai/simulationmissing@napi-rs/canvasonv2; package-level typecheck for changed packages passes.