fix(app): preserve composer caret after requests#36503
Open
Hona wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a session composer UX regression where the contenteditable caret position could be lost when request docks temporarily unmount the composer, ensuring the caret is restored before the next printable key is inserted.
Changes:
- Persist the latest contenteditable caret position into prompt state on editor blur.
- When auto-focusing the composer on the first printable keypress, also restore the caret to the saved position (or prompt end).
- Add an E2E regression test that exercises caret preservation across question-dock mount/unmount.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/app/src/pages/session.tsx | Restores the prompt editor caret when auto-focusing the composer in the document keydown handler. |
| packages/app/src/components/prompt-input.tsx | Persists the current caret position to the prompt store on blur so it can be restored after unmount/remount. |
| packages/app/e2e/regression/session-request-docks.spec.ts | Adds a regression test verifying the caret is restored before typing after a request dock closes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification