fix(tui): respect sidebar width threshold#36469
Open
aditya-vithaldas wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
the
needs:compliance
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential duplicate found:
This PR appears to be addressing the same issue: sidebar behavior in narrow terminals and respecting terminal width constraints. The current PR (#36469) references issue #36417, which may also be covered by PR #36414. You should check if #36414 is still open and whether it already solves the same problem. |
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #36417
Type of change
What does this PR do?
Removes the temporary
sidebarOpenoverride from the TUI session view. Sidebar visibility is now controlled by the persistedautoorhidesetting and the existing terminal-width check, so enabling it cannot force the sidebar over content in a narrow terminal.How did you verify your code works?
bun typecheckfrompackages/tuibun test test/index.test.tsxScreenshots / recordings
Not included. The change restores the existing narrow-terminal hidden state and does not introduce new UI.
Checklist