fix(core): support legacy message rows#27702
Open
shantur wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #27701 #21941 #25847
Type of change
What does this PR do?
Older local sessions can contain message and part rows written before the current
MessageV2schemas required several fields. After upgrading opencode, those historical rows can fail when read through session message APIs or services, not only when importing an old export.This PR adds shared compatibility normalization in
MessageV2hydration and reuses it from import. Current schemas remain strict, but legacy rows are repaired at the read/import boundary before decoding or returning them.The compatibility handling covers missing message
agent, usermodel, assistantparentID, andstep-finish.reasonfields. The investigation found import started surfacing the issue when it moved from inserting raw message data to parsing throughMessageV2.Infoin64fb9233b, but the same historical shape can affect existing local DB sessions through/session/:id/messageand related read paths.How did you verify your code works?
bun test test/cli/import.test.ts test/session/messages-pagination.test.tsfrompackages/opencodebun typecheckfrompackages/opencodebun turbo typecheckMessageV2schemas; all 3312 messages decoded successfullyScreenshots / recordings
Not a UI change.
Checklist