fix(deps): revert effect to 4.0.0-beta.57 (pre-regression)#26067
Open
stephanschielke wants to merge 2 commits intoanomalyco:devfrom
Open
fix(deps): revert effect to 4.0.0-beta.57 (pre-regression)#26067stephanschielke wants to merge 2 commits intoanomalyco:devfrom
stephanschielke wants to merge 2 commits intoanomalyco:devfrom
Conversation
effect@4.0.0-beta.58 (Effect-TS/effect-smol#2098) changed Stream.mkUint8Array from an immutable Channel.runFold pattern to a mutable accumulator. Combined with bun build --compile --minify (PR anomalyco#22362), JSC freezes the fold accumulator object between iterations, causing "Attempted to assign to readonly property" on all tool calls after the first. Reverting to beta.57 (last known-good). The bump was a routine chore (anomalyco#25524) with no feature dependency. Related: anomalyco#25873, Effect-TS/effect-smol#2126
6 tasks
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential Duplicates Found:
These are alternative solutions to the same problem rather than true duplicates. The current PR (#26067) takes the dependency revert approach, while #26066 and #25867 represent the other two alternative fixes mentioned in the PR description. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #25873
Related: #25835
Type of change
What does this PR do?
Reverts
effectfrom4.0.0-beta.59to4.0.0-beta.57in the workspace catalog.The bump from beta.57 to beta.59 was a routine chore (PR #25524) with no feature dependency. beta.58 (Effect-TS/effect-smol#2098) changed
Stream.mkUint8Arrayfrom an immutableChannel.runFold(newUint8Arrayper iteration) to a mutable accumulator (acc.bytes += ...; acc.arrays.push(...); return acc). Combined withminify: truein the build script (PR #22362), JSC freezes the fold accumulator between iterations, causingAttempted to assign to readonly property.v1.14.33 (minify + beta.57) worked. v1.14.34+ (minify + beta.59) crashes.
@effect/opentelemetryand@effect/platform-nodealready use beta.57 in the workspace.Upstream: Effect-TS/effect-smol#2126, Effect-TS/effect-smol#2127
Related PRs (alternative fixes):
runForEachHow did you verify your code works?
Stream.mkUint8Arrayis the only relevantStream.tschangebun installresolves cleanly to beta.57 (already cached from@effect/opentelemetryand@effect/platform-node)TS2416inbus/global.ts, same ondev)Screenshots / recordings
N/A (dependency version change, not a UI change)
Checklist