fix(ci): add concurrency control to prevent race in hash updates#18286
Closed
milyord wants to merge 1 commit intoanomalyco:devfrom
Closed
fix(ci): add concurrency control to prevent race in hash updates#18286milyord wants to merge 1 commit intoanomalyco:devfrom
milyord wants to merge 1 commit intoanomalyco:devfrom
Conversation
Multiple concurrent workflow runs on the same branch can race to commit hashes.json. When an older commit's run finishes after a newer commit's run, stale hashes overwrite correct ones. Add concurrency group per-branch with cancel-in-progress to ensure only the latest commit's hashes are computed and committed.
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
github-actions
bot
added
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Author
|
Closing as duplicate of #18228 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #
Type of change
What does this PR do?
Multiple concurrent workflow runs on the same branch can race to commit hashes.json. When an older commit's run finishes after a newer commit's run, stale hashes overwrite correct ones.
Add concurrency group per-branch with cancel-in-progress to ensure only the latest commit's hashes are computed and committed.
If you paste a large clearly AI generated description here your PR may be IGNORED or CLOSED!
How did you verify your code works?
Can't verify, I have no access to CI but it's a simple enough fix
Screenshots / recordings
If this is a UI change, please include a screenshot or recording.
Checklist
If you do not follow this template your PR will be automatically rejected.