fix(task): preserve subagent todo permissions#18202
Open
armin1024 wants to merge 1 commit intoanomalyco:devfrom
Open
fix(task): preserve subagent todo permissions#18202armin1024 wants to merge 1 commit intoanomalyco:devfrom
armin1024 wants to merge 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: I found one potentially related PR that may be addressing a similar issue: Related PR:
The current PR (18202) appears to be fixing a specific regression where |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #12938
Type of change
What does this PR do?
Fixes a subagent permissions bug where
todowrite/todoreadbecame unavailableinside child sessions created through
task, even when the subagent explicitlyallowed them.
Root cause:
TaskToolpassedtodowrite: falseandtodoread: falseintoSessionPrompt.prompt()todoreadwas also missing fromToolRegistryChanges:
todowrite/todoreadinpackages/opencode/src/tool/task.tsTodoReadToolinpackages/opencode/src/tool/registry.tsHow did you verify your code works?
tasktodoreadis registeredtypecheckforpackages/opencodeScreenshots / recordings
N/A
Checklist