fix: route prompt input to parent session when viewing subagent#17172
Open
HadiDawoud wants to merge 1 commit intoanomalyco:devfrom
Open
fix: route prompt input to parent session when viewing subagent#17172HadiDawoud wants to merge 1 commit intoanomalyco:devfrom
HadiDawoud wants to merge 1 commit intoanomalyco:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #4422
Type of change
What does this PR do?
When viewing a subagent (child) session, the Prompt component was always
sending input to route.sessionID which is the child session ID. So any
input typed while in a subagent view would go to the incorrect wrong session.
Fixed by passing session()?.parentID ?? route.sessionID to the Prompt's
sessionID prop, so when you're in a child session it routes input correctly to the
parent instead.
How did you verify your code works?
Ran the project locally with bun dev, navigated into a subagent session
and verified that input now goes to the parent session correctly.
Screenshots / recordings
Terminal UI change
Unable to capture a before/after screenshot as the bug
requires navigating into an active subagent session to reproduce. The fix is
a one-line change to the sessionID prop on the Prompt component.
Checklist