fix(install): prioritize .bash_profile over .bashrc on macOS#17152
Closed
nil957 wants to merge 1 commit intoanomalyco:devfrom
Closed
fix(install): prioritize .bash_profile over .bashrc on macOS#17152nil957 wants to merge 1 commit intoanomalyco:devfrom
nil957 wants to merge 1 commit intoanomalyco:devfrom
Conversation
On macOS, Terminal.app and iTerm open login shells by default, which source ~/.bash_profile but not ~/.bashrc. The installer was checking ~/.bashrc first, causing the PATH export to be written to a file that's never sourced in new terminal sessions. This commit reorders the config file candidates for bash on macOS to check ~/.bash_profile first, ensuring the opencode PATH is correctly set for login shells. Linux behavior is unchanged since non-login interactive shells (the default for most terminal emulators) source ~/.bashrc. Fixes anomalyco#17132
github-actions
bot
added
the
needs:compliance
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential Duplicate FoundPR #17131: "fix: prioritize .bash_profile over .bashrc for bash on macOS" This appears to be the same fix addressing the identical issue - prioritizing |
Author
|
Closing as duplicate of #17131 which addresses the same issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On macOS, Terminal.app and iTerm open login shells by default, which source
~/.bash_profilebut not~/.bashrc. The installer was checking~/.bashrcfirst, causing the PATH export to be written to a file that's never sourced in new terminal sessions.Changes
~/.bash_profilefirst~/.bashrcTesting
Tested on macOS with bash:
~/.bashrcexists~/.bash_profileopencodeis foundFixes #17132