Skip to content

fix(core): make cache read cost fallback to input token cost #17130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benjamincburns wants to merge 1 commit into
base: dev
Choose a base branch
from
+99 −2
Open

fix(core): make cache read cost fallback to input token cost #17130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/opencode/src/provider/provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -775,7 +775,7 @@ export namespace Provider {
input: model.cost?.input ?? 0,
output: model.cost?.output ?? 0,
cache: {
read: model.cost?.cache_read ?? 0,
read: model.cost?.cache_read ?? model.cost?.input ?? 0,
write: model.cost?.cache_write ?? 0,
},
experimentalOver200K: model.cost?.context_over_200k
Expand Down Expand Up @@ -947,7 +947,12 @@ export namespace Provider {
input: model?.cost?.input ?? existingModel?.cost?.input ?? 0,
output: model?.cost?.output ?? existingModel?.cost?.output ?? 0,
cache: {
read: model?.cost?.cache_read ?? existingModel?.cost?.cache.read ?? 0,
read:
model?.cost?.cache_read ??
existingModel?.cost?.cache.read ??
model?.cost?.input ??
existingModel?.cost?.input ??
0,
write: model?.cost?.cache_write ?? existingModel?.cost?.cache.write ?? 0,
},
},
Expand Down
92 changes: 92 additions & 0 deletions packages/opencode/test/provider/provider.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,6 +492,98 @@ test("model cost defaults to zero when not specified", async () => {
})
})

test("cache read cost falls back to input cost when not specified", async () => {
await using tmp = await tmpdir({
init: async (dir) => {
await Bun.write(
path.join(dir, "opencode.json"),
JSON.stringify({
$schema: "https://opencode.ai/config.json",
provider: {
"test-provider": {
name: "Test Provider",
npm: "@ai-sdk/openai-compatible",
env: [],
models: {
"test-model": {
name: "Test Model",
tool_call: true,
limit: { context: 128000, output: 4096 },
cost: {
input: 5,
output: 15,
},
},
},
options: {
apiKey: "test-key",
},
},
},
}),
)
},
})
await Instance.provide({
directory: tmp.path,
fn: async () => {
const providers = await Provider.list()
const model = providers["test-provider"].models["test-model"]
expect(model.cost.input).toBe(5)
expect(model.cost.output).toBe(15)
expect(model.cost.cache.read).toBe(5)
expect(model.cost.cache.write).toBe(0)
},
})
})

test("cache read cost uses explicit value when provided", async () => {
await using tmp = await tmpdir({
init: async (dir) => {
await Bun.write(
path.join(dir, "opencode.json"),
JSON.stringify({
$schema: "https://opencode.ai/config.json",
provider: {
"test-provider": {
name: "Test Provider",
npm: "@ai-sdk/openai-compatible",
env: [],
models: {
"test-model": {
name: "Test Model",
tool_call: true,
limit: { context: 128000, output: 4096 },
cost: {
input: 5,
output: 15,
cache_read: 1,
cache_write: 2,
},
},
},
options: {
apiKey: "test-key",
},
},
},
}),
)
},
})
await Instance.provide({
directory: tmp.path,
fn: async () => {
const providers = await Provider.list()
const model = providers["test-provider"].models["test-model"]
expect(model.cost.input).toBe(5)
expect(model.cost.output).toBe(15)
expect(model.cost.cache.read).toBe(1)
expect(model.cost.cache.write).toBe(2)
},
})
})

test("model options are merged from existing model", async () => {
await using tmp = await tmpdir({
init: async (dir) => {
Expand Down
Loading