fix(db): harden sqlite3 signal handling#17116
Open
tobwen wants to merge 1 commit intoanomalyco:devfrom
Open
Conversation
This was referenced Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #17114
Type of change
What does this PR do?
This hardens
opencode dbwhen it launches the interactivesqlite3shell.The user-visible bug was that after leaving
opencode dbwithCtrl-C, the terminal could come back in a broken state and echo later input character-by-character on separate lines instead of returning cleanly to the shell.This change fixes that by tightening the interactive
sqlite3signal and exit handling. It also closes the Bun SQLite handle in query mode withfinally, handlessqlite3spawn failures explicitly, preserves non-zero child exit codes, and avoids the globalSIGHUPhandler collapsing signal-derived exit status.In short: the command now behaves much more predictably when
sqlite3is interrupted or terminated.How did you verify your code works?
bun typecheckinpackages/opencodebun run buildinpackages/opencodeopencode dbwithCtrl-Cand confirmed the shell returned cleanly instead of echoing later input character-by-characterScreenshots / recordings
Before
After
Checklist