Open
Conversation
kitlangton
force-pushed
the
feat/branded-provider-model-id
branch
from
7f50fd4 to
08bf97c
Compare
kitlangton
force-pushed
the
feat/branded-provider-model-id
branch
from
bf89141 to
41ad8b2
Compare
kitlangton
force-pushed
the
feat/branded-provider-model-id
branch
from
41ad8b2 to
e346f2e
Compare
kitlangton
force-pushed
the
feat/branded-remaining-ids
branch
from
19452df to
562689c
Compare
kitlangton
force-pushed
the
feat/branded-provider-model-id
branch
from
e346f2e to
3da87ad
Compare
processor.ts already has a branded ProviderID from Provider.Model, and fromError's ctx.providerID is already typed as ProviderID — no need to double-wrap with .make().
Use typed local variable instead of inline cast for Provider.sort.
…after model.json is read with ProviderID/ModelID in the generic, removing the need for .make() when returning the result.
kitlangton
force-pushed
the
feat/branded-provider-model-id
branch
from
3da87ad to
180cc02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProviderIDandModelIDschemas and thread them through provider, session, server, and ACP validation paths