refactor(import): use .parse() at boundaries instead of manual .make()#17106
Open
kitlangton wants to merge 1 commit intodevfrom
Open
refactor(import): use .parse() at boundaries instead of manual .make()#17106kitlangton wants to merge 1 commit intodevfrom
kitlangton wants to merge 1 commit intodevfrom
Conversation
kitlangton
force-pushed
the
feat/branded-remaining-ids
branch
from
6d948bf to
753f330
Compare
kitlangton
force-pushed
the
feat/parse-at-import-boundary
branch
5 times, most recently
from
4c81469 to
46c8d70
Compare
kitlangton
force-pushed
the
feat/branded-remaining-ids
branch
from
19452df to
562689c
Compare
kitlangton
force-pushed
the
feat/parse-at-import-boundary
branch
from
46c8d70 to
d2fc03a
Compare
…) calls Parse external SDK data through branded Zod schemas (Session.Info, MessageV2.Info, MessageV2.Part) at the import boundary. This replaces manual SessionID.make/MessageID.make/PartID.make wrapping with a single .parse() call per entity, which both validates and brands in one step.
kitlangton
force-pushed
the
feat/parse-at-import-boundary
branch
from
d2fc03a to
3896f1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SessionID.make()/MessageID.make()/PartID.make()/WorkspaceID.make()wrapping in the import command with.parse()calls on the branded Zod schemasSession.Info.parse(),MessageV2.Info.parse(), andMessageV2.Part.parse()validate and brand in one step at the import boundaryTest plan