fix(opencode): handle shell-escaped parentheses in drag-drop file paths#17082
Open
vdmkotai wants to merge 1 commit intoanomalyco:devfrom
Open
fix(opencode): handle shell-escaped parentheses in drag-drop file paths#17082vdmkotai wants to merge 1 commit intoanomalyco:devfrom
vdmkotai wants to merge 1 commit intoanomalyco:devfrom
Conversation
Terminals like Ghostty shell-escape special characters when drag-dropping files. The paste handler only unescaped backslash-space but not other metacharacters like parentheses, causing silent attachment failure for filenames like 'image (1).png'. Use /\\([^a-zA-Z0-9])/g to unescape all shell metacharacters while preserving Windows path separators (backslash + alphanumeric). Fixes anomalyco#17075
github-actions
bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #17075
Type of change
What does this PR do?
When you drag-drop a file like
image (1).pnginto Ghostty, the terminal shell-escapes the path:image\ \(1\).png. The TUI paste handler only unescaped\(backslash-space) but not\(or\), soFilesystem.readArrayBufferreceived the wrong path, failed silently, and the paste was swallowed.Changed the regex from
/\\ /gto/\\([^a-zA-Z0-9])/g— this unescapes all shell metacharacters while keeping Windows path separators intact (backslash followed by alphanumeric is never a shell escape).How did you verify your code works?
Wrote a test script covering 17 cases: the bug scenario (shell-escaped parens/brackets), single-quoted paths, Windows paths (
C:\Users\...), plain paths, edge cases (trailing backslash, double backslash, backslash-digit). All 17 pass — bug is fixed and Windows paths are preserved.Screenshots / recordings
N/A — TUI-only change, no UI modification.
Checklist