fix(sync): strip discount suffix from Kilo model IDs when resolving canonical base model - #4960
Open
levdad wants to merge 2 commits into
Open
fix(sync): strip discount suffix from Kilo model IDs when resolving canonical base model#4960levdad wants to merge 2 commits into
levdad wants to merge 2 commits into
Conversation
…anonical base model
Contributor
Action items
|
Update the logic for determining if a model name should be inherited from the base model to include the `:free` suffix. This ensures that both `:discounted` and `:free` variants are correctly identified as route variants during the model building process.
Contributor
Action items
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the Kilo provider sync returns model IDs with a suffix, the canonical base model resolution fails because the suffix is not part of the canonical model identity. This strips before calling
resolveCanonicalBaseModel.Change
packages/core/src/sync/providers/kilo.ts, strip:discountedfrommodel.idbefore resolving the canonical base model.Validation
bun validateshould pass.