Make display count assertions robust - #14
Merged
Merged
Conversation
IPython's captured display hook output can use different execution counts depending on whether run_cell stores history. Newer IPython currently emits Out[0] for the tests' default run_cell calls, while the tests hard-code Out[1]. The exact display count is not the behavior under test here. Normalize the Out[...] prefix before comparing stdout so the tests continue to check the autoimport messages and displayed values without depending on IPython's internal prompt counter. Validation: PYTHONPATH=src pytest -vv
Owner
|
Thanks for the clean fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IPython's captured display hook output can use different execution counts depending on whether run_cell stores history. Newer IPython currently emits Out[0] for the tests' default run_cell calls, while the tests hard-code Out[1].
The exact display count is not the behavior under test here. Normalize the Out[...] prefix before comparing stdout so the tests continue to check the autoimport messages and displayed values without depending on IPython's internal prompt counter.
Validation: PYTHONPATH=src pytest -vv