feat (/): Chinese translation update#589
Conversation
|
Hi! Thank you for submitting a PR :D We really can't merge anything right now as the CI that tests everything before a PR gets merged is broken. We are trying to find a fix as of now. Thanks! |
|
@ok-coder1 let's rewrite the CI and remove unessary checks. we don't want contirbutions to be stuck. |
got it, thanks <3 |
|
@anmol098 Do you have a Discord? If yes, please join
https://discord.gg/9UNSmBUKnX
|
@anmol098 @pseusys |
File "/home/runner/work/waka-readme-stats/waka-readme-stats/sources/main.py", line 213, in main
init_github_manager()
~~~~~~~~~~~~~~~~~~~^^
File "/home/runner/work/waka-readme-stats/waka-readme-stats/sources/manager_github.py", line 22, in init_github_manager
GitHubManager.prepare_github_env()
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
File "/home/runner/work/waka-readme-stats/waka-readme-stats/sources/manager_github.py", line 52, in prepare_github_env
GitHubManager._REMOTE_NAME = f"{GitHubManager.USER.login}/{GitHubManager.USER.login}"
^^^^^^^^^^^^^^^^^^^^^^^^This is what's causing the CI to fail. |
- name: Save Branch Name Without Slashes 📛
if: ${{ github.ref != 'refs/heads/master' }}
env:
BRANCH_NAME: ${{ github.head_ref || github.ref_name }}
run: |
BRANCH_NAME=${{ env.BRANCH_NAME }}
BRANCH_NAME=${BRANCH_NAME////_}
echo BRANCH_NAME=${BRANCH_NAME} >> $GITHUB_ENVIf I may ask, what's the use of removing slashes from the branch's name? |
As you can see, the branch name is used as a part of an uploaded artefact name - and slashes are not allowed there (but common in branch names). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
solusops
left a comment
There was a problem hiding this comment.
Readme is outdated due to past change to the format.
Please check the locales directory, and use the existing Chinese template if possible.
translation.json looks good to me
Moved contributed translation according to other's suggestion. Extra changes and corrections are also included. :3
See previous commit.
Ah I see. Changes were all moved to that file with some tweaks. Thanks! :3 |
|
README stats current output: 🐱 My GitHub Data
I'm a Night 🦉 📅 I'm Most Productive on Sunday 📊 This Week I Spent My Time On I Mostly Code in JavaScript Timeline You can use this website to view the generated base64 image. Last Updated on 12/01/2026 06:36:40 UTC |
sry about that :(
solusops
left a comment
There was a problem hiding this comment.
Thank You so much for the contribution!
translation.json