feat: toggleable incrementer for "Learn ahead limit" and "Timebox time limit"#21336
Open
Yousuf24100286 wants to merge 4 commits into
Open
feat: toggleable incrementer for "Learn ahead limit" and "Timebox time limit"#21336Yousuf24100286 wants to merge 4 commits into
Yousuf24100286 wants to merge 4 commits into
Conversation
|
First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible. |
Contributor
|
Important Maintainers: This PR contains Strings changes
|
Collaborator
|
Sorry, but, umm... you made the same mistake as the previous assignee despite there being clear instructions on how it should look like. |
Contributor
Author
@ZornHadNoChoice pls review. is this how I was supposed to do it ? |
Contributor
|
Snapshot diff report vs
All 1 changed screenshotsPreferencesScreenshotTest
|
Collaborator
|
Almost. There should be a vertical bar like in the "Sync URL" toggle. |
Contributor
Author
@ZornHadNoChoice pls review. |
Collaborator
|
It looks good, but I have no idea about the functionality or the code. I'm not a dev. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Purpose / Description
The "Learn ahead limit" and "Timebox time limit" required user to manually enter 0 to disable the feature.
Now added a toggle switch to enable/disable the limit.
Fixes
Approach
ToggleableIncrementerNumberRangePreferenceCompatNumberRangePreferenceCompatHow Has This Been Tested?
assemblePlayDebugbuilds successfully,lintPlayDebugpassesScreenshots
Checklist
Please, go through these checks before submitting the PR.