fix: controls dialog side display#21078
Open
BrayanDSO wants to merge 1 commit into
Open
Conversation
david-allison
approved these changes
May 20, 2026
Member
david-allison
left a comment
david-allison
left a comment
There was a problem hiding this comment.
LGTM, non blocking requests
| override fun getDisplayString(mappableBinding: MappableBinding): String { | ||
| val side = (preference as? ReviewerControlPreference)?.side | ||
| return if (side != null) { | ||
| mappableBinding.binding.toDisplayString(requireContext()) |
Member
There was a problem hiding this comment.
Add a comment, or a test/needstest
david-allison
added
Needs Second Approval
BrayanDSO
force-pushed
the
fix/controls-desc
branch
from
0486bfe to
1e71eb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
How Has This Been Tested?
Emulator 31
Checklist
Please, go through these checks before submitting the PR.