feat(manage-notetypes): use more material components#21072
Conversation
|
Snapshot diff report vs
All 3 changed screenshotsManageNotetypesScreenshotTest
|
This comment was marked as resolved.
This comment was marked as resolved.
Maybe remove it directly, it provides no relevant information IMO just clutters the toolbar. I also agree with ZornHadNoChoice, it doesn't look too good. I made this remark with Settings as well. |
lukstbit
left a comment
There was a problem hiding this comment.
I'm ok with the changes with a discussion on the toolbar style to settle this once for all.
Love the screenshot tests.
0a8a5ed to
f5599ae
Compare
|
Important Maintainers: This PR contains Strings changes
|
f5599ae to
98a3525
Compare
|
|
AppBar is fine. I question hiding the FAB. I don't see this happening on other apps (Gmail contracts the FAB, but that's not a hide) and the RecyclerView seems to have sufficient bottom padding so the FAB won't obscure the bottom row |
|
98a3525 to
9895f9f
Compare
|
It's something Material has on its own catalog app, so it is an acceptable practice in Material design. With many notetypes the bottom padding feels quite weird IMO. It looks like someone oversaw an extra enormous margin while designing the screen With auto-hide, it can be half the original size Also, "Adding" may not be a frequent action for a lot of people. Maybe it shouldn't even be a FAB, just a |
|
I added the margin at the bottom to protect the content from being hidden by the fab and also to leave space for the multi selection info panel that also appears at the bottom. |
I get that and it was a good choice, but the padding may still be weird for the people that don't notice that |
9895f9f to
18bc31f
Compare



Purpose / Description
Hide the FAB on scroll and use a Material App Bar
How Has This Been Tested?
Emulator 31
Details
Screen_recording_20260518_081453.webm
Screenshot tests
Details
./gradlew :AnkiDroid:recordRoborazziPlayDebug -Pscreenshot --tests "com.ichi2.anki.notetype.*" -Ptheme=all
Learning (optional, can help others)
Describe the research stage
Links to blog posts, patterns, libraries or addons used to solve this problem
Checklist
Please, go through these checks before submitting the PR.