Improve card browser scrolling performance.#21068
Open
Galal-20 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
This PR addresses the jittery scrolling issue in the Card Browser.
The performance degradation was primarily caused by frequent, synchronous JNI calls to the backend during onBindViewHolder and expensive UI operations like repeated background drawable updates and regex processing for every row being bound.
Fixes
Approach
To restore smooth scrolling, the following optimizations were implemented:
Backend Caching: Added an LruCache for BrowserRow data to minimize expensive JNI calls during scrolling.
How Has This Been Tested?
scroll.mp4
Checklist