fix(SetDueDateDialog) : TransactionTooLargeException#21055
Open
Alok-Silswal wants to merge 1 commit into
Open
Conversation
Member
|
merged! Please rebase + remove the merge commits in the history |
Alok-Silswal
force-pushed
the
fix-setduedate-idsfile
branch
2 times, most recently
from
4d601f6 to
bb13e23
Compare
Alok-Silswal
force-pushed
the
fix-setduedate-idsfile
branch
from
bb13e23 to
f87854e
Compare
| ) | ||
| Timber.i("Showing 'set due date' dialog for %d cards", cardIds.size) | ||
| } | ||
| suspend fun newInstance( |
Member
There was a problem hiding this comment.
nit: If you add an overload with context(fragment: Fragment), you should be able to keep the call sites clean
| override fun onCreate(savedInstanceState: Bundle?) { | ||
| super.onCreate(savedInstanceState) | ||
| viewModel.init(cardIds, fsrsEnabled) | ||
| viewModel.init(cardIds.toLongArray(), fsrsEnabled) |
Member
There was a problem hiding this comment.
nit: why not change the signature of init
| get() = requireArguments().requireBoolean(ARG_FSRS) | ||
|
|
||
| override fun onCreate(savedInstanceState: Bundle?) { | ||
| super.onCreate(savedInstanceState) |
Member
There was a problem hiding this comment.
🐉 You now need to handle the fact that cardIds does not exist because the file was deleted
lukstbit
added
Needs Author Reply
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Set Due Date Dialog crashed when >60k browsed cards are selected and the user puts the app in the background.
Fixes
Approach
Imitated the approach used in
FindAndReplaceDialogFragment.ktand Export Dialog to deal with this issue by using the classIdsFilerather than usingBundle, which was overflowing when the capacity exceeded, thereby causing the crash.Modified
newInstanceAPI in unit tests to make it consistent with the approach used in this PR.How Has This Been Tested?
Tested on my phone (Android 14, Xiaomi / HyperOS) using a debug build.
Both these observations have been tested. Video attached as evidence.
Checklist
Please, go through these checks before submitting the PR.
SetDueDate.Fix.Evidence.mp4